Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix skipped List component test #3321

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jun 26, 2024

What's the problem?

What's the solution?

Variables need be be reinstated when a new list item is added, otherwise they hold onto their old references and are invalid.

Comment on lines +92 to +93
"proposal.units.residential.total.units.development.newBuild": 3,
"proposal.units.residential.total.units.development.changeOfUseTo": 2,
Copy link
Contributor Author

@DafyddLlyr DafyddLlyr Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may look like I'm "fixing" the expected output to make the test pass, but in this instance it's actually an incorrect payload.

This now matches the other (already passing) test example here -

"proposal.units.residential.total.units.development.newBuild": 3,
"proposal.units.residential.total.units.development.changeOfUseTo": 2,

And we can see that development is added to the path here -

Object.entries(baseSums).forEach(([k, v]) => {
if (v > 0) {
formattedSums[`${fn}.total.units.development.${k}`] = v;
}
});

@DafyddLlyr DafyddLlyr requested a review from a team June 26, 2024 09:57
Copy link

github-actions bot commented Jun 26, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and relates well to the PR description.

@DafyddLlyr DafyddLlyr merged commit 367c3fc into main Jun 26, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/list-component-skip-test branch June 26, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants