Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: List component radio remove extra margin #3322

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ianjon3s
Copy link
Contributor

What does this PR do?

Quick one: adds a negative margin to </RadioGroup> in the List component to negate the extra margin caused by using this inline (radio button rows have margin-bottom to ensure layout spacing).

Before vs after:

image

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice and simple, thanks for picking this one up!

Been bugging me but hadn't yet turned my attention to it 🙌

Copy link

github-actions bot commented Jun 26, 2024

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s merged commit fb336c2 into main Jun 26, 2024
12 checks passed
@ianjon3s ianjon3s deleted the ian/list-component-radio-margin-fix branch June 26, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants