test: Outstanding List component validation tests #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
|
Removed vultr server and associated DNS entries |
DafyddLlyr
commented
Jun 26, 2024
| @@ -16,6 +15,7 @@ import { DESCRIPTION_TEXT, ERROR_MESSAGE } from "../../shared/constants"; | |||
| import BasicRadio from "../../shared/Radio/BasicRadio"; | |||
| import type { NumberField, QuestionField, TextField } from "../model"; | |||
| import { useListContext } from "./Context"; | |||
| import { get } from "lodash"; | |||
There was a problem hiding this comment.
This change was required as the formik's getIn() doesn't correctly handle fn fields using dot notation (e.g. proposal.propertyType).
Docs: https://formik.org/docs/api/fieldarray#fieldarray-validation-gotchas
DafyddLlyr
force-pushed
the
dp/list-todo-validation-tests
branch
from
bfc8f5a to
4f6287a
Compare
DafyddLlyr
commented
Jun 27, 2024
Comment on lines
+87
to
+90
| // Do not allow new item to be added if it will exceed max | ||
| if (schema.max && formik.values.userData.length === schema.max) { | ||
| return setMaxError(true); | ||
| } |
There was a problem hiding this comment.
Moving this here feels like a better user experience than just checking this when a user hits "Continue" (and may have added too many items).
6 tasks
jessicamcinchak
approved these changes
Jun 28, 2024
DafyddLlyr
force-pushed
the
dp/list-todo-validation-tests
branch
from
4f6287a to
6d75bb7
Compare
DafyddLlyr
force-pushed
the
dp/list-todo-validation-tests
branch
from
6d75bb7 to
770d301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
test.todo()s following on from feat: List component - form validation and values #3217ChecklistFieldInputfor List component #3304 (dependant on merge order)