refactor: Editor forms tidy up and unify #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
ianjon3s
changed the title
ianjon3s
changed the title
DafyddLlyr
reviewed
Jun 28, 2024
Comment on lines
11
to
17
| export default function InputLabel(props: { | ||
| label: string; | ||
| children: ReactNode; | ||
| hidden?: boolean; | ||
| htmlFor?: string; | ||
| id?: string; | ||
| }) { |
There was a problem hiding this comment.
Suggested change
| export default function InputLabel(props: { | |
| label: string; | |
| children: ReactNode; | |
| hidden?: boolean; | |
| htmlFor?: string; | |
| id?: string; | |
| }) { | |
| export default function InputLabel(props: PropsWithChildren<{ | |
| label: string; | |
| hidden?: boolean; | |
| htmlFor?: string; | |
| id?: string; | |
| }>) { |
nit: A little bit easier / simpler / better matches our code style 👌
Take a look at https://blog.logrocket.com/react-children-prop-typescript/
There was a problem hiding this comment.
Thanks, have updated
| <InputGroup label="Why it matters"> | ||
| <InputRow> | ||
| <InputGroup flowSpacing> | ||
| <InputLabel label="Why it matters"> |
There was a problem hiding this comment.
Do we want to remove the placeholder values now if we're adding labels here?
There was a problem hiding this comment.
Good shout, the label + placeholder combo is already in place but it makes sense to have one or the other.
There was a problem hiding this comment.
Nice to also pick up changes here 🙌
|
Thanks for the review @DafyddLlyr , updated commit incoming with your suggestions + general settings commented out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors settings pages to use a simplified and unified structure.
Summary of changes:
<InputLabel>for editor<EditorRow>renamed to<SettingsSection>to differentiate from<ModalSection>as used in the graph editor<InputDescription>renamed to<SettingsDescription>To do before merging