Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove 'unique' property from List schema (QuestionField) #3331

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jun 27, 2024

What does this PR do?

Why this change?

  • It's not currently used or necessary for existing schemas
  • There's likely better ways of handling this (e.g. pre-populating forms, not putting the onus on the user to manage this)
  • It's only being enforced via the UI, and not in the schema currently

@DafyddLlyr DafyddLlyr changed the title feat: Remove 'unique' property from List schema feat: Remove 'unique' property from List schema (QuestionField) Jun 27, 2024
@DafyddLlyr DafyddLlyr marked this pull request as ready for review June 27, 2024 16:34
Copy link

github-actions bot commented Jun 27, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/remove-unique-from-list branch from 7c5d743 to c37ad55 Compare June 28, 2024 10:12
@DafyddLlyr DafyddLlyr merged commit e873e11 into main Jun 28, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/remove-unique-from-list branch June 28, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants