Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make val optional in SetValue component #3333

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jun 28, 2024

What does this PR do?

  • Makes val an optional field in the SetValue component if the operation is removeAll
  • Updates types
  • Conditionally hides form field

image

@DafyddLlyr DafyddLlyr requested a review from a team June 28, 2024 10:58
@DafyddLlyr
Copy link
Contributor Author

Copy link

github-actions bot commented Jun 28, 2024

Removed vultr server and associated DNS entries

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍

@DafyddLlyr DafyddLlyr merged commit afda8e6 into main Jun 28, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/optional-val-removeAll branch June 28, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants