Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Repointing data fetches from Teams table to team_settings table #3334

Merged
merged 22 commits into from
Jul 3, 2024
Merged

feat: Repointing data fetches from Teams table to team_settings table #3334

merged 22 commits into from
Jul 3, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Jun 28, 2024 •
edited
Loading

What does this PR do?

This PR follows work done on the team_settings table implementation. This PR focuses on work to change references from the settings and notifyPersonalisation columns to the new team_settings table which replace these columns.

Changes have been made to the planx-core repo as well to coincide with these changes, contained here: theopensystemslab/planx-core#424

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@RODO94 RODO94 force-pushed the rory/team-settings-data-repointing branch 2 times, most recently from d8ae1f9 to b88721e Compare June 28, 2024 13:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (1)

  • public.team_settings permissions:

    insert select update delete
    public ➕/➖
    4 added column permissions
    insert select update
    public ➕ email_reply_to_id
    ➕ help_email
    ➕ help_opening_hours
    ➕ help_phone

@RODO94 RODO94 force-pushed the rory/team-settings-data-repointing branch 2 times, most recently from 640fb0d to db99fa7 Compare July 1, 2024 15:15
DafyddLlyr
DafyddLlyr requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comment / suggestions, all very minor 👍

@RODO94 RODO94 requested a review from DafyddLlyr July 2, 2024 08:22
RODO94 added 17 commits July 2, 2024 16:52
@RODO94 RODO94 force-pushed the rory/team-settings-data-repointing branch from f12bf14 to f65b25b Compare July 2, 2024 15:56
@RODO94 RODO94 merged commit dc215a2 into main Jul 3, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/team-settings-data-repointing branch July 3, 2024 08:14
@DafyddLlyr DafyddLlyr mentioned this pull request Jul 3, 2024
Merged
@RODO94
Copy link
Contributor Author

RODO94 commented Jul 5, 2024

Create team_settings table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RODO94 @DafyddLlyr