Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix broken lockfiles #3358

Merged
merged 1 commit into from
Jul 1, 2024
Merged

chore: Fix broken lockfiles #3358

merged 1 commit into from
Jul 1, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jul 1, 2024

Take 2 on #3355

pnpm i --fix-lockfile run on each project. Docs: https://pnpm.io/cli/install#--fix-lockfile

@DafyddLlyr DafyddLlyr requested a review from a team July 1, 2024 14:39
Copy link

github-actions bot commented Jul 1, 2024

Removed vultr server and associated DNS entries

@RODO94
Copy link
Contributor

RODO94 commented Jul 1, 2024

@DafyddLlyr were the code changes generated by the pnpm i --fix-lockfile ?

@DafyddLlyr
Copy link
Contributor Author

@RODO94 Yep, the lockfiles are all generated and not written. I actually think that this PR should resolve the issue - theopensystemslab/planx-core#433

Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand of the creation of the yml file, this looks good to me and the method to generate it makes sense.

@DafyddLlyr DafyddLlyr merged commit 0f05cc9 into main Jul 1, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/fix-lockfiles-v2 branch July 1, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants