chore: show number units on inactive List if defined #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Jul 3, 2024
| @@ -21,6 +22,7 @@ export function formatSchemaDisplayValue( | |||
| ) { | |||
| switch (field.type) { | |||
| case "number": | |||
| return field.data.units ? `${value} ${field.data.units}` : value; | |||
There was a problem hiding this comment.
This is my only change !
Rest are formatting only, I guess prettier has changed with recent dependabot updates? Sorry for extra noise.
There was a problem hiding this comment.
Ah yep that makes sense - I'll open a pnpm lint:fix PR to fix this in a oner and try to remember this next time there's a prettier update 👍
|
Removed vultr server and associated DNS entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small thing spotted during demo this morning!
Since many schemas are using a Number input to collect area, we should ensure the
m2units is consistently displayed on both the active & inactive List when it's defined.