feat: team_settings form error validation
#3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
The
|
Error Message GuidanceThe tone of voice guiding the error messaging follows information here: How to write good planning service content |
DafyddLlyr
approved these changes
Jul 5, 2024
|
|
||
| export interface Props { | ||
| label?: string; | ||
| inline?: boolean; | ||
| color?: string; | ||
| errorMessage?: string | undefined; |
There was a problem hiding this comment.
Suggested change
| errorMessage?: string | undefined; | |
| errorMessage?: string; |
nit: This is the same thing but a bit more terse and matches our code style. The ? following the property name indicates that this property can be undefined.
| </Popover> | ||
| ) : null} | ||
| </Root> | ||
| <ErrorWrapper error={props.errorMessage || undefined} id="settings-error"> |
There was a problem hiding this comment.
We should use a unique id here, for example colour-picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following previous work done on
team_settingsform in the Editor: #3366This PR will introduce the Error Handling while making changes to shared
SettingsFormto handle error messaging on an input level rather than form level.The only change to an Input Component will be to the
<ColourPicker>which is used in theThemesettings forms. The properrorMessagehas been added to the<ColourPicker>component to enable this input level error messaging