feat: Add error handling for failed file uploads #3369
Conversation
| isValid={ | ||
| props.hideDropZone || | ||
| slots.every((slot) => slot.url && slot.status === "success") | ||
| } |
There was a problem hiding this comment.
@ianjon3s Having a condition here on the isValid prop means that the "Continue" button is disabled, which goes against our general a11y principles.
Did we ever discuss this one, or is removing this here the right way to go?
There was a problem hiding this comment.
Good catch, I think I missed this one when inventoring / fixing disabled "Continue" buttons here if you want to add to existing Trello checklist for collective memory! https://trello.com/c/elmTB1Pq/2828-disabled-buttons-and-unexpected-input-functionality-usability
There was a problem hiding this comment.
I've actually removed it in this PR - added to checklist and marked as done!
| <ErrorWrapper | ||
| error={ | ||
| status === "error" | ||
| ? "Upload failed, please remove file and try again" | ||
| : undefined | ||
| } | ||
| > |
There was a problem hiding this comment.
Adding this wrapper is the change here, the diff below is purely a whitespace change due to the extra indentation but git hasn't quite caught this.
|
Removed vultr server and associated DNS entries |
What does this PR do?
"error"Future improvements