Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Single EditorNavMenu instance with wired up routing #3370

Merged
merged 6 commits into from
Jul 4, 2024
Merged

feat: Single EditorNavMenu instance with wired up routing #3370

merged 6 commits into from
Jul 4, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jul 4, 2024 •
edited
Loading

What does this PR do?

  • Addresses outstanding issues from feat: In-page editor navigation menus #3336
  • Creates a single instance of EditorNavMenu, integrated into a react-navi Layout
    • This is now using absolute URLs in order to keep routing working as expected
  • Remove repeated Dashboard component, now integrated into AuthenticatedLayout (as this is now only used once)

Next steps...

  • Handle standard wrapper/containers
  • Fix Flow layout
  • Remove Settings component
  • Remove dropdown menu options
  • Hide menu items based on permissions (i.e. global settings)

@DafyddLlyr DafyddLlyr force-pushed the dp/single-menu-instance branch from 4eaa4b4 to 9ce2932 Compare July 4, 2024 10:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr requested a review from a team July 4, 2024 11:41
@DafyddLlyr DafyddLlyr marked this pull request as ready for review July 4, 2024 11:42
ianjon3s
ianjon3s approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly on the front-end

@DafyddLlyr DafyddLlyr merged commit 514ca16 into ian/editor-navigation-menus Jul 4, 2024
10 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/single-menu-instance branch July 4, 2024 17:50
@ianjon3s
Copy link
Contributor

ianjon3s commented Jul 9, 2024

Thanks for this @DafyddLlyr, I've moved the remaining task list over to the parent PR

@ianjon3s
Copy link
Contributor

ianjon3s commented Jul 9, 2024

Editor restyling

ianjon3s pushed a commit that referenced this pull request Jul 9, 2024
@DafyddLlyr @ianjon3s
feat: Single EditorNavMenu instance with wired up routing (#3370)
8d6d77b
DafyddLlyr added a commit that referenced this pull request Jul 11, 2024
@DafyddLlyr
feat: Single EditorNavMenu instance with wired up routing (#3370)
39e47b2
DafyddLlyr added a commit that referenced this pull request Jul 12, 2024
@DafyddLlyr
feat: Single EditorNavMenu instance with wired up routing (#3370)
7c81c53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianjon3s ianjon3s ianjon3s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @ianjon3s