Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: team_settings column rename from boundary_json to boundary_bbox #3375

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Jul 5, 2024

What does this PR do?

This PR will set up work to add a outer boundary json to the database for a local authority using the data in the boundary_url column

Following this work, when a user updates the boundary_url column, it will trigger a fetch to get the GeoJSON and then pass it through turf.js to turn it into a boundary_bbox JSON. This initial migration will enable easier follow on work.

Copy link

github-actions bot commented Jul 5, 2024

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (1)

  • public.team_settings permissions:

    insert select update delete
    api /
    platformAdmin /
    public /
    teamEditor /
    8 updated column permissions
    insert select update
    api ➕ boundary_bbox
    ➖ boundary_json
    platformAdmin
    public
    teamEditor

@RODO94
Copy link
Contributor Author

RODO94 commented Jul 5, 2024

@DafyddLlyr @jessicamcinchak I seem to be pulling in a few quotation mark changes on the .yml file, is this a prettier issue?

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is merged I'll line up a production deploy so that the sync scripts can also be easily updated to point at the new column 👍

Copy link

github-actions bot commented Jul 5, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr mentioned this pull request Jul 5, 2024
@DafyddLlyr
Copy link
Contributor

DafyddLlyr commented Jul 5, 2024

@RODO94 I'm not sure if it's a prettier issue - maybe a different version of the Hasura CLI or something like that? Ideally we wouldn't commit a noisy change unnecessarily, but it doesn't make a functional difference if either ' or " is used in this file.

@RODO94 RODO94 merged commit 89adc20 into main Jul 5, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/team-settings-bbox-migration branch July 5, 2024 11:56
RODO94 added a commit to theopensystemslab/planx-core that referenced this pull request Jul 5, 2024
…438)

## What does this PR do?

This PR updates functions and types relating to ``team_settings`` with
the new ``boundary_bbox`` column which replaces the previous
``boundary_json`` column:
theopensystemslab/planx-new#3375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants