Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an audit table for applications submitted via S3 and Power Automate #3397

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jul 10, 2024

Quick final step in helping Barnet go live with S3/Power Automate submissions soon.

Adds a basic audit table for tracking application data.

@jessicamcinchak
Copy link
Member Author

Copy link

github-actions bot commented Jul 10, 2024

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Tracked Tables (1)

  • public.s3_applications permissions:

    insert select update delete
    api
    18 added column permissions
    insert select update
    api ➕ created_at
    ➕ id
    ➕ session_id
    ➕ team_slug
    ➕ webhook_request
    ➕ webhook_response
    ➕ created_at
    ➕ id
    ➕ session_id
    ➕ team_slug
    ➕ webhook_request
    ➕ webhook_response
    ➕ created_at
    ➕ id
    ➕ session_id
    ➕ team_slug
    ➕ webhook_request
    ➕ webhook_response

Copy link

github-actions bot commented Jul 10, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak marked this pull request as ready for review July 10, 2024 08:36
@jessicamcinchak jessicamcinchak requested a review from a team July 10, 2024 08:36
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question / comment!

@@ -0,0 +1,11 @@
CREATE TABLE "public"."s3_applications" (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that these applications will be automatically picked up by the submission_services_log view as that's reading Hasura metadata tables directly right?

However, I think that the submission_services_summary view will require an update to also read from this new table.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question - you're right:

  • submission_services_log is automatically picking up these records because it reads from Hasura events
  • submission_services_summary will need to be manually updated (then Metabase too?) to join to this new audit table so analytics can be correctly tracked

I'd prefer to pick this up in a follow-up PR !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes total sense! ✅

@jessicamcinchak jessicamcinchak merged commit be4bb9d into main Jul 10, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/s3-apps-audit-table branch July 10, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants