-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an audit table for applications submitted via S3 and Power Automate #3397
Conversation
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Tracked Tables (1)
|
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question / comment!
@@ -0,0 +1,11 @@ | |||
CREATE TABLE "public"."s3_applications" ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that these applications will be automatically picked up by the submission_services_log
view as that's reading Hasura metadata tables directly right?
However, I think that the submission_services_summary
view will require an update to also read from this new table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question - you're right:
submission_services_log
is automatically picking up these records because it reads from Hasura eventssubmission_services_summary
will need to be manually updated (then Metabase too?) to join to this new audit table so analytics can be correctly tracked
I'd prefer to pick this up in a follow-up PR !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, makes total sense! ✅
Quick final step in helping Barnet go live with S3/Power Automate submissions soon.
Adds a basic audit table for tracking application data.