Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: React warnings on PlanningConstraints component #3399

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix: React warnings on PlanningConstraints component #3399

merged 2 commits into from
Jul 10, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jul 10, 2024 •
edited
Loading

What does this PR do?

  • Adds missing key prop
  • Ensures we use correct semantic HTML hierarchy by not wrapping HTML in paragraph element
image image image

@DafyddLlyr DafyddLlyr requested a review from a team July 10, 2024 11:06
jessicamcinchak
jessicamcinchak approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit fdc543f into main Jul 10, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/planning-constraints-react-warnings branch July 10, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak