fix: Correctly populate flow settings and status #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Jul 12, 2024
| await getFlowMetadata(flow, req.params.team); | ||
| useStore.setState({ flowSettings, flowAnalyticsLink, isFlowPublished }); | ||
| useStore.setState({ flowAnalyticsLink, isFlowPublished }); |
There was a problem hiding this comment.
flowSettings is not needed here - it's only actually used and displayed when we navigate to the settings page.
|
Removed vultr server and associated DNS entries |
ianjon3s
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
When creating a new flow, the status shows as "online" if accessed via the Editor Menu. If we check the database, this is set to "offline" (and all tests for triggers etc are passing) - it's just a frontend visual bug.
What's the cause?
Somewhere in the Editor Menu work a regression has slipped in which changed the way data was fetched. When accessing it via the dropdown menu, there's no issues. When accessing via the Editor Menu, the correct data is not fetched.
This is what's causing E2E tests to fail in #3408 & #3409
What's the solution?
GetFlowqueries)