chore: refactor formatRawProjectTypes (take 2)

[jessicamcinchak]

See theopensystemslab/planx-core#445 for context!

Regression tests timing out on this branch - no errors, not sure why yet ! https://github.com/theopensystemslab/planx-new/actions/runs/9911311940 (likely related to team_settings - let's merge to main & fix forward!)

Will drop project_types table in a followup PR.

[github-actions]

Removed vultr server and associated DNS entries

[DafyddLlyr]

One suggested simplification / tidy up 👍

[DafyddLlyr]

nit: We have to use this slightly awkward syntax when calling an async function inside a useEffect() which required us to define the async function in scope.

Now it's no longer async I think we can just simplify this by dropping the useEffect() and associated useState() - this isn't a reactive value, just a formatted prop.

const projectType = formatRawProjectTypes(rawProjectTypes);

// or if the above is a little slow/intensive (I don't really think so?)

const projectType = useMemo(formatRawProjectTypes(rawProjectTypes), [rawProjectTypes])

[jessicamcinchak]

Good catch ! Updated here 24ba79f (no indication it needs a useMemo, but we can keep an eye on that in prod)

[DafyddLlyr]

@jessicamcinchak Finally resolved the outstanding issues here -

• A few team setting queries and types I missed (sorry!)
• The very frustrating TypeError: Cannot read properties of undefined (reading 'alteredNodes') we've hit a few times with Playwright tests (basically leads to timeouts and unhelpful reports as they don't catch the dialog this pops up in).
  • As with last time, this was resolved by updating Axios
• A project type update in E2E regressions tests

✅ Regression tests passing against branch here - https://github.com/theopensystemslab/planx-new/actions/runs/9944116858/job/27469441913