Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add reference code field to team settings #3431

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jul 16, 2024

What does this PR do?

  • Adds a field for reference code to the team setting page
  • This is a required field for submissions (metadata.organisation) and should be exposed via the Editor

image

@@ -62,7 +62,7 @@ export default function ContactForm({ formikConfig, onSuccess }: FormProps) {
onChange={(event) => {
onChangeFn("homepage", event);
}}
value={formik.values.homepage}
value={formik.values.homepage ?? ""}
Copy link
Contributor Author

@DafyddLlyr DafyddLlyr Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homepage is nullable, this resolves a Formik warning.

image

@@ -62,7 +63,7 @@ const GeneralSettings: React.FC = () => {
<Container maxWidth="formWrap">
<SettingsSection>
<Typography variant="h2" component="h3" gutterBottom>
General
Settings
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now matches the new Editor menu.

@DafyddLlyr DafyddLlyr requested a review from a team July 16, 2024 10:01
@DafyddLlyr DafyddLlyr marked this pull request as ready for review July 16, 2024 10:01
Copy link

github-actions bot commented Jul 16, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Form is rendering correctly and pulling in codes from local authorities

@DafyddLlyr DafyddLlyr merged commit 81fd176 into main Jul 16, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/add-reference-code-field branch July 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants