feat: Initial frontend search proof of concept with Fuse.js #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/fuse-js
branch
4 times, most recently
from
e64dec4 to
2cf94a8
Compare
|
@RODO94 @jessicamcinchak - Still plenty of TODO comments, and outstanding tasks + some planx-core / flow navigation questions for the next dev call, but I'm opening this up for review just now to get feedback on the code that's here. Once I've resolved a few questions on theopensystemslab/planx-core#462 (which this PR relies on) we can progress this (still feature flagged) to |
RODO94
reviewed
Jul 24, 2024
DafyddLlyr
changed the title
DafyddLlyr
added a commit
to theopensystemslab/planx-core
that referenced
this pull request
Jul 29, 2024
## What? - Adds a required `parentId` property to `IndexedNode` - Updates `sortFlow()` logic to match PlanX graph structure ## Why? - Implemented in theopensystemslab/planx-new#3435 - For navigation to a node to work from search, we need to know the "path" through the graph to a node - Currently `sortFlow()` returns an optional `parentId`, despite all nodes having a parent (apart from the root node). It's more accurate to give all nodes a parent. This makes things a bit easier when constructing a path (upcoming PR) - The current implementation of `sortFlow()` doesn't quite match our graph structure. When reaching the next child of the root node, the current parentId is maintained instead of falling back to the root. This worked well for treating the graph as a linear structure to split it up be portal names (pseudo sections), but doesn't work in terms of actually describing the hierarchy of the graph (required to build a valid PlanX URL). - **The difference really comes down to "previous node" vs. "parent node"** - The flow will still retain the same sorted order, `root.edges[0]` → `root.edges[1]` → `root.edges[2]` → etc Note: This should not impact any current functionality. `sortFlow()` and `findNextNodeOfType()` are not used anywhere in PlanX currently. ### Example - I have a root node with two edges - I navigate through the branches of the first edges until there are no more edges - My next step will be the second edge of the root node - **Currently:** The parentId for `root.edges[1]` will be set to the very final node of `root.edges[0]` (previous node) - **This PR:** The parentId for `root.edges[1]` will be set to "_root" (parent node)
jessicamcinchak
approved these changes
Jul 30, 2024
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Portal.tsx
Show resolved
Hide resolved
editor.planx.uk/src/pages/FlowEditor/components/Sidebar/Search.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
useSearch()hook as a facade for this libraryWhy search in the frontend?
Why Fuse.js?
Next steps...
I'll pick up the below as follow up PRs -
getPathForFlow()planx-core#463data.fnanddata.valScreen.Recording.2024-07-19.at.16.52.26.mov