Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production deploy #3442

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Production deploy #3442

merged 1 commit into from
Jul 19, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jul 19, 2024

So that we'll have auditing & notifications in place if Barnet launches as expected on Monday, July 22.

@jessicamcinchak jessicamcinchak requested a review from a team July 19, 2024 11:05
};

const getSessionIdFromEvent = (data: EventData, type: EventType) =>
({
"bops-submission": (data as BOPSEventData).session_id,
"uniform-submission": (data as UniformEventData).payload?.sessionId,
"email-submission": (data as EmailEventData).session_id,
"s3-submission": (data as S3EventData).session_id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessicamcinchak is s3-submissions a reference to S3 doc storage?

Also, are we now setting up a new notification system because Barnet are submitting applications in a new way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ! This is in reference to API modules/send/s3 which works as follows:

  • Creates a validated or non-validated ODP Schema JSON file payload depending on application type
  • Uploads it as a private file to our AWS S3 user data bucket
  • Pings a webhook endpoint provided by the council with a notification message including the file link that the application is ready to download and process (in Barnet's case, the webhook and processing is configured via Power Automate, but in theory it could be more generic than that).

It's essentially a more automated option than "Send to email" for bulk-processing submissions.

The notifications are already in place for our other "Send destinations" (they're council agnostic), and I'm adding them for this destination now too that the first council using this integration is ready to go live soon (we don't notify on staging, so hasn't been any reason to setup until now!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessicamcinchak So are they using power automate to extract data from the file in S3?

@jessicamcinchak jessicamcinchak merged commit 513a891 into production Jul 19, 2024
7 checks passed
Copy link

Removed vultr server and associated DNS entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants