feat: Add duplicate name logic to Rename flow onClick #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RODO94
commented
Jul 25, 2024
| @@ -128,13 +128,15 @@ export function AddButton({ | |||
|
|
|||
| interface FlowItemProps { | |||
| flow: any; | |||
| flows: any; | |||
There was a problem hiding this comment.
Use of the any type followed current practices in the Team component, may be worth a refactor in future to follow TS best practices
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR builds on previous work completed in #3445 to add duplicate name validation when you add a new flow.
What that previous PR didn't pick up was adding the validation to the renaming process.
In order to allow a comparison between the new name and the current list of names, I had to alter the props being passed to the
<FlowItem>component which contains the<StyledSimpleMenu>.The alteration was just to add
flowsinto the component.