feat: Move analytics link to editor navigation #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
reviewed
Jul 31, 2024
|
Removed vultr server and associated DNS entries |
DafyddLlyr
requested changes
Jul 31, 2024
DafyddLlyr
approved these changes
Aug 1, 2024
| })<{ isActive: boolean; disabled?: boolean }>( | ||
| ({ theme, isActive, disabled }) => ({ | ||
| shouldForwardProp: (prop) => prop !== "isActive", | ||
| })<{ isActive: boolean }>(({ theme, isActive }) => ({ |
There was a problem hiding this comment.
As disabled is an IconButton prop, you should still be able to access it here.
})<{ isActive: boolean }>(({ theme, isActive, disabled }) => ({There was a problem hiding this comment.
Ah yes, I've updated, allows a consistent use of the prop with the CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Example with analytics link (manually set):
https://3481.planx.pizza/testing/flow-with-analytics-link
Example without analytics link:
https://3481.planx.pizza/testing/flow-without-analytics-link