-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: add share button for flow links #3483
Closed
Closed
Changes from 50 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
30cae3d
add option for link
RODO94 01a6c92
add skeleton layout
RODO94 430a345
openable dialog added without content
RODO94 325e732
add test link for dialog item
RODO94 01fdece
add header to dialog box
RODO94 0af7127
add export to theme setting image wrapper and added to link header:
RODO94 5dddd17
adjust img wrap and add stack comp to handle link list
RODO94 2cccbf8
swap export imageWrapper to bespoke within component
RODO94 e812312
remove export from shared comp
RODO94 68760d9
add changes to dialog box
RODO94 a330d3d
add comp for containing link logic
RODO94 838561c
add isPublished logic to published link
RODO94 f08f3e9
remove old copy message
RODO94 1610886
add domain to Link list
RODO94 52d0c5b
remove console log and string for string replace
RODO94 a4c8267
add planx-core changes and toggle button
RODO94 ee3f778
add stylin in line with figma
RODO94 3538dd3
styling and permissions
RODO94 80ba13e
fix padding on copy button and switch name to view in line with the text
RODO94 f56b658
alter copy button name to view button
RODO94 026a0ec
remove redundant styling
RODO94 1aa1fa8
fix issue with text under publish button
RODO94 329beb3
add href for links
RODO94 a25baab
revert sidebar toggle button
RODO94 4348a4b
remove z-index style from root
RODO94 ea6f633
add domain to store init team query
RODO94 2a8f163
add theme to initTeamStore
RODO94 cdda20c
add dialog as separate comp
RODO94 46a30a1
add logic for styling the header
RODO94 b011484
fix logic for opening and closing dialog in sidebar
RODO94 78c8ed0
style change for buttons to allow single line txt
RODO94 616bb7a
reconfig dialog open state to trigger from button
RODO94 ca510f1
add logic to only look at last instance
RODO94 10fdc7c
setting up code for new dialog designs
RODO94 ad75b92
progress modular components for new publish link structure:
RODO94 e23fdbd
refine link comps and types
RODO94 4df9605
refactor header logic which creates new array instead of mutating cur…
RODO94 b1b5f23
stylin updates
RODO94 4d8d507
tidying types, props, and imported modules
RODO94 27e77ce
add console and refresh buttons
RODO94 c4d8629
create logic for published descriptions and service settings nav
RODO94 2949ae0
adjust publish link comp structure and logic
RODO94 e1171ad
add href to Link comp
RODO94 34bfdc2
add copybutton to published link comp
RODO94 e9b241b
add flowSlug to subdomain
RODO94 9e2f471
only make subdomain truthy if teamDomain exists logic added
RODO94 25f1470
refine text of links
RODO94 6283e66
adjust text for links
RODO94 606c00d
switch local state to global state for flow status
RODO94 adffcbf
swap debug console icon as it was same as toggle
RODO94 2cd239c
alter button styling to match global button style
RODO94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,8 @@ const Flow = ({ breadcrumbs = [] }: any) => { | |
href: `${window.location.pathname.split(id)[0]}${id}`, | ||
})); | ||
|
||
console.log(useStore.getState().flowStatus); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oops lingering |
||
|
||
return ( | ||
<> | ||
<ol id="flow" data-layout={flowLayout} className="decisions"> | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I'm following the introduction of
isOutsideEditor
and why this newbackgroundColor
condition is necessary?state.previewEnvironment
does semi-confusingly return "editor" rather than "standalone" for/draft
&/preview
routes - but I think we'd want to update this directly rather than introduce a new variable?Also, broadly, how does changing the header color related to sharing links?