Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup MapAndLabel with React Context and schema input fields per map feature #3501

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Aug 8, 2024

A few key changes:

  • Rebases to the latest @opensystemslab/map pre-release so we can drawMany
  • Adds the concept of a "Schema" to the Editor modal, with an initial option for "Trees" (very similar to List)
  • Displays a form reflecting the schema fields for each feature plotted on the map; "resetting" the map also removes the forms
    • Each form is rendered in a MUI Vertical Tabs panel (docs) - still a bit of polishing needed to match latest Figmas!
  • Refactors the main component to use React Context (docs)
    • This had big benefits for reducing validation complexity and prop drilling with the List component, and we'll have similar layers of complexity to manage here
    • To start, I copied a lot directly from the List - this gets us to a play-with-able thing quick, but we'll definitely want to reduce duplication and extract some logic (especially around "Fields" I think) going forward - but this exercise should help us better understand which logic bits these components will share and what will need to be unique !

Screenshot from 2024-08-11 22-25-17

This component is feature-flagged and there's lots of known gaps/bugs/follow-ups to spin out of this, including and not limited to:

  • Form validation & error handling
  • handleSubmit - add form inputs to GeoJSON properties?
  • Polish up designs to match Figma; can we highlight map features based on active tab?? (set color property on drawGeojsonData ??)
  • Debug shifty map labels on modify

@jessicamcinchak jessicamcinchak changed the title feat: setup MapAndLabel with React Context feat: setup MapAndLabel with React Context and schema input fields per map feature Aug 11, 2024
Copy link

github-actions bot commented Aug 26, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak marked this pull request as ready for review August 26, 2024 15:58
@jessicamcinchak jessicamcinchak requested a review from a team August 26, 2024 15:58
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comment / questions / fix-forwards. Solid groundwork here! 👍

@jessicamcinchak jessicamcinchak merged commit 7bbd1c0 into main Aug 27, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/map-and-label-context branch August 27, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants