Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: Add "no-nested-ternary" ESLint rule to projects" #3536

Closed
wants to merge 1 commit into from

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Aug 20, 2024

Reverts #3514

Also running regression tests against this branch here: https://github.com/theopensystemslab/planx-new/actions/runs/10470664105

We've had issues with SWR requests validating correctly since this change merged, reverting this to see if it's connected (seems doubtful, but we're really scratching our heads with this bug!) - full context in this thread: https://opensystemslab.slack.com/archives/C04EEBR1E0P/p1724054282014549

Copy link

github-actions bot commented Aug 20, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak
Copy link
Member Author

Closing this one as confirmed not source of SWR bug (regression tests pass at same spot as elsewhere, requests fail to validate on pizza) !

@jessicamcinchak jessicamcinchak deleted the revert-3514-dp/no-nested-ternary branch August 20, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant