fix: when proposing a new address, map should display at full width and lower zoom #3538
Conversation
|
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
No changes necessary to how we store boundaries or calculate bounding-boxes - that's all correct, was purely a viewport / display issue here I believe!
Thanks for the clear explanation and investigation here, good to see that this is just a simple viewport issue 👍
Code reads as correct and all looks good - but having some issues with the Pizza. Maybe unrelated to changes here, can you verify?
When I load a map I get the error "Error: Unimplemented type: 3" which is caused when a 404 is returned by the vector tile provider.
Also getting an issue when loading up West Berks' LDC service - https://3538.planx.pizza/west-berkshire/apply-for-a-lawful-development-certificate/published?analytics=false
Fixes issues raised by Tewkesbury & West Berks linked here: https://trello.com/c/TAY09Mpw/2980-diagnose-and-fix-map-center-zoom-issue-when-displaying-team-boundaries
Quick but key changes here:
FullWidthWrappersimilar to our other interactive maps (eg DrawBoundary) for more real-estatezoomfrom14to10which seems to better accomodate more spacious rural councils while still working for London boroughs like Lambeth toodrawGeojsonDataBufferprop - we don't need this for initial render, and when coming "back" after having plotted a new address, the map defaults will still be smartly zoomed into & centered on your existing pointNo changes necessary to how we store boundaries or calculate bounding-boxes - that's all correct, was purely a viewport / display issue here I believe!
The viewport is still "clipped" to the council boundary, and now that we're starting at a lower zoom, don't expect to be able to zoom out much from the starting location, but it should feel more "centered" on the full council now (rather than the center of the boundary like before).
Before & afters:
Tewkesbury
West Berks
Lambeth (did not report issue, but is quite a different scope boundary than above examples, so want to confirm it still displays reasonably too!)
