Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new editor - error handling and enhancements #3543

Merged
merged 43 commits into from
Aug 28, 2024
Merged

feat: add new editor - error handling and enhancements #3543

merged 43 commits into from
Aug 28, 2024

Conversation

jamdelion
Copy link
Contributor

@jamdelion jamdelion commented Aug 21, 2024 •
edited
Loading

Trello ticket: https://trello.com/c/piMcGsJa/2973-add-user-in-editor

✅ Done

Done Demo image
Show toast message on success
Add in 'close modal' test
Handle 'user already exists' error scenario

❓ Questions:

How to handle:

  • failing to fetch from the store (get team id)
  • failing to execute the graphQL mutation (server-side error)

Demos

Aug-27-2024 15-06-12

Aug-27-2024 15-07-23

jamdelion and others added 30 commits August 5, 2024 15:40
@jamdelion
fix: refactor Team component folder structure
a4d60bf
@jamdelion
Basic "add new editor" button on team editors table
f7e87fb
@jamdelion
Merge main
5f38c8a
@jamdelion
Hide button behind feature flag
d2f9c59
@jamdelion
Rename test
0a566a1
@jamdelion
Test button appears within team editors table only
edc221b
@jamdelion
Style button correctly
fe7ce77
@jamdelion
Basic open modal functionality
12df25c
@jamdelion
Move modal to new component and add static input fields
2975369
@jamdelion
Extract setup helper from test
3240488
@jamdelion
Extract props type
50c0a9c
@jamdelion
Use formik for form validation and submission
f6d7f25
@jamdelion
Implement changes requested
b419666
@jamdelion
Merge branch 'jh/add-team-editor-button' into jh/validate-add-team-ed…
5d189eb 
…itor
@jamdelion
Get basic createUser working
c5f31a8
@jamdelion
Merge branch 'main' into jh/validate-add-team-editor
0f368f5
@jamdelion
Basic addUserToTeam mutation
4a27c5c
@jamdelion
Split out queries into own folder
3f81d7b
@jamdelion
Tidy up - move type defs and schemas
fc91022
@jamdelion
Fix import
4ec6cb6
@jamdelion
Start writing a test for form submission - close modal
e616c02
@jamdelion
Optimistically update the table when fetching complete, plus refactors
237a0ee
@jamdelion
Test that new row added to team editors table
29624c1
@jamdelion @DafyddLlyr
Update editor.planx.uk/src/pages/FlowEditor/components/Team/component…
522e2d7 
…s/AddNewEditorModal.tsx

Co-authored-by: Dafydd Llŷr Pearson <[email protected]>
@jamdelion
Use teamId from store instead of fetchCurrentTeam
37c8a3f
@jamdelion
Combine createUser and addToTeam mutations into one
b6a12d2
@jamdelion
Use store to optimistically update, plus refactor member filtering
2e1fedc
@jamdelion
Fix tests
8a3459d
@jamdelion
Merge branch 'main' into jh/validate-add-team-editor
126d6d4
@jamdelion
Show toast message on success
a5dfb84
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@jamdelion jamdelion mentioned this pull request Aug 22, 2024
Merged
@jamdelion jamdelion marked this pull request as ready for review August 27, 2024 14:14
@jamdelion jamdelion requested a review from a team August 27, 2024 14:14
DafyddLlyr
DafyddLlyr approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

editor.planx.uk/src/pages/FlowEditor/components/Team/errors/addNewEditorErrors.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

editor.planx.uk/src/pages/FlowEditor/components/Team/tests/mocks/mockTeamMembersData.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible that git just didn't pick up on a file move/rename here, but I think this is just a duplicate of editor.planx.uk/src/pages/FlowEditor/components/Team/tests/exampleTeamMembersData.tsx

@jamdelion jamdelion merged commit 0b6b010 into main Aug 28, 2024
12 checks passed
@jamdelion jamdelion deleted the jh/add-editor-error-handling branch October 28, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamdelion @DafyddLlyr