Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct logic for slotsSchema validation #3550

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

DafyddLlyr
Copy link
Contributor

What does this PR do?

Addresses issues outlined in this ticket - https://trello.com/c/zYOIK4d1/2996-allow-users-to-bypass-upload-and-label-exemptions-not-working-correctly

Component requires either all files to be optional or files uploaded to be > 0. Recommended files are however not treated as optional, effectively being treated as if required. The allFilesOptional exemption should really be a noFilesRequired exemption, as the only time a users should be blocked from proceeding without uploading anything is when one or more files are required. Related issue: Even when all files are set to optional, with no uploaded files the component still always triggers the “Remove files which failed to upload” error.

This is now fixed (with added tests). The "Remove files which failed to upload” error was over-eager and giving false positives, the allFilesOptional test has been updated to make the syntax a little clearer, but it's still logically the same.

@DafyddLlyr DafyddLlyr requested a review from a team August 23, 2024 06:28
@DafyddLlyr
Copy link
Contributor Author

Copy link

github-actions bot commented Aug 23, 2024

Removed vultr server and associated DNS entries

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@jessicamcinchak
Copy link
Member

I'll go ahead and merge this one & flag to Jonny at standup this morning that it's ready to test on staging 👍

@jessicamcinchak jessicamcinchak merged commit daae386 into main Aug 23, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the dp/fual-all-optional-files branch August 23, 2024 08:15
@augustlindemer
Copy link
Collaborator

Working perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants