Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update store on flow status change #3552

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

DafyddLlyr
Copy link
Contributor

Small UX improvement I noticed when turning a flow online/offline for testing.

By directly updating the store, Zustand will reactively update our UI so we don't have to reload the component (e.g. via navigation) to see the update.

Screen.Recording.2024-08-23.at.08.32.11.mov

@DafyddLlyr DafyddLlyr requested a review from a team August 23, 2024 07:34
Copy link

github-actions bot commented Aug 23, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good improvement.

@jessicamcinchak jessicamcinchak merged commit 9ab39f1 into main Aug 23, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the dp/update-store-on-flow-status-change branch August 23, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants