Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating remaining REACT_APP_* envs to VITE_APP_* #3562

Merged
merged 2 commits into from
Aug 26, 2024
Merged

chore: Updating remaining REACT_APP_* envs to VITE_APP_* #3562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e93bf37
chore: Updating remaining REACT_APP envs to VITE_APP
DafyddLlyr Aug 26, 2024
324e706
fix: Missing slack notification env [skip pizza]
DafyddLlyr Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/tests/ui-driven/install-dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ cd $(dirname "$0")

source ../../../.env

(cd ../../../editor.planx.uk && pnpm install --frozen-lockfile && REACT_APP_ENV=test pnpm build)
(cd ../../../editor.planx.uk && pnpm install --frozen-lockfile && VITE_APP_ENV=test pnpm build)

if [ -z "${CI}" ]; then
echo "Please make sure you have Chrome installed on this machine."
Expand Down
4 changes: 3 additions & 1 deletion editor.planx.uk/src/@planx/components/MapAndLabel/Public.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ function MapAndLabelComponent(props: Props) {
teamSettings?.boundaryBBox &&
JSON.stringify(teamSettings?.boundaryBBox)
}
osProxyEndpoint={`${process.env.REACT_APP_API_URL}/proxy/ordnance-survey`}
osProxyEndpoint={`${
import.meta.env.VITE_APP_API_URL
}/proxy/ordnance-survey`}
osCopyright={`© Crown copyright and database rights ${new Date().getFullYear()} OS (0)100024857`}
collapseAttributions={window.innerWidth < 500 ? true : undefined}
/>
Expand Down
4 changes: 3 additions & 1 deletion editor.planx.uk/src/@planx/components/shared/Schema/InputFields/MapFieldInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ export const MapFieldInput: React.FC<Props<MapField>> = (props) => {
maxZoom={23}
latitude={Number(passport?.data?._address?.latitude)}
longitude={Number(passport?.data?._address?.longitude)}
osProxyEndpoint={`${process.env.REACT_APP_API_URL}/proxy/ordnance-survey`}
osProxyEndpoint={`${
import.meta.env.VITE_APP_API_URL
}/proxy/ordnance-survey`}
osCopyright={`Basemap subject to Crown copyright and database rights ${new Date().getFullYear()} OS (0)100024857`}
clipGeojsonData={
teamSettings?.boundaryBBox &&
Expand Down
2 changes: 1 addition & 1 deletion editor.planx.uk/src/pages/FlowEditor/components/Settings/ServiceSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ const ServiceSettings: React.FC = () => {
const message = `${emoji[status]} *${teamSlug}/${flowSlug}* is now ${status} (@Silvia)`;

return axios.post(
`${process.env.REACT_APP_API_URL}/send-slack-notification`,
`${import.meta.env.VITE_APP_API_URL}/send-slack-notification`,
{
message: message,
},
Expand Down
Loading