feat: display static map for inactive List "map" fields #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
approved these changes
Aug 27, 2024
|
|
||
| switch (drawType) { | ||
| case "Point": | ||
| // Our "geojsonData" layer doesn't have a "point" style yet, so make due with center marker for now! |
There was a problem hiding this comment.
Ha! Totally hadn't appreciated this, smart solution here!
|
Removed vultr server and associated DNS entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last piece in order to have an end-to-end List option demo ready for tmrw morning - shows a static map when the List item is inactive for any "map" field types.
Hit a funny quirk here testing with "points" where I realised a limitation in the map repository - our
geojsonDatalayer has only ever accounted for polygons before and doesn't currently have a "point" style associated with it ! So will make that update in@opensytemslab/mapfor a future release, and in the meantime we just slightly adjust our rendering rules based ondrawTypehere 👍(Also sorry Rory @RODO94 I know we bookmarked this task to your name last week, but trying to keep momentum ahead of demos & UR deadline! will be plenty more followup tasks when you're ready to come back into works to trees !)