Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Submission Email SettingsForm #3569

Closed
wants to merge 3 commits into from

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Aug 27, 2024

What does this PR do?

This PR continues work in line with the Trello Ticket: https://trello.com/c/dVsTQpZZ/2984-allow-editors-to-see-update-their-teams-submission-email-in-team-settings-form

I have set up a "Submission Information" form in the Team Settings area. This comes with standard Formik wiring up with ErrorWrapper following patterns established in the other forms.

@RODO94 RODO94 force-pushed the rory/submission-email-form-input branch from 2b38bbf to 05ac060 Compare August 27, 2024 10:58
@RODO94
Copy link
Contributor Author

RODO94 commented Aug 27, 2024

@DafyddLlyr @jessicamcinchak I added my new planx-core ref to this branch and ran pnpm i in the relevant files. I rebased to fix a conflict with main, but now the lock files have a lot of changes... more than I would expect.

Tried rerunning pnpm i and pushing it back up, it removed some but not all.

Any thoughts on this? Is this a problem?

Changes are small enough that I can delete the branch and re-do them. Just wondering what happened?

@RODO94 RODO94 closed this Aug 27, 2024
Copy link

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr deleted the rory/submission-email-form-input branch August 27, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant