Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Submission Form added to General Settings #3570

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Aug 27, 2024

What does this PR do?

This PR continues work in line with the Trello Ticket: https://trello.com/c/dVsTQpZZ/2984-allow-editors-to-see-update-their-teams-submission-email-in-team-settings-form

I have set up a "Submission Information" form in the Team Settings area. This comes with standard Formik wiring up with ErrorWrapper following patterns established in the other forms.

Copy link

github-actions bot commented Aug 27, 2024

Removed vultr server and associated DNS entries

@RODO94 RODO94 changed the title Rory/submission email settings form feat: Submission Form added to General Settings Aug 27, 2024
@RODO94 RODO94 marked this pull request as ready for review August 27, 2024 13:48
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but the data sync on the pizza failed (so I can't log in to test!)

image

It can occasionally happen, it's not caused by a change in this PR. Two options to resolve this here - SSH onto Pizza and manually run script again, or just log into Vultr and destroy and recreate Pizza and associated DNS records for the PR.

I'm not sure if we've stepped through either of these processes yet. If you want to pair on either, or just try one out yourself, just let me know 👌

@RODO94 RODO94 force-pushed the rory/submission-email-settings-form branch from f785c6c to 81ee562 Compare August 27, 2024 14:51
@RODO94
Copy link
Contributor Author

RODO94 commented Aug 27, 2024

Restart Vultr but still same thing so I have rebased on main and re run CI

@RODO94 RODO94 requested a review from DafyddLlyr August 27, 2024 14:59
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - nice and simple 👌

@RODO94 RODO94 merged commit f5323c9 into main Aug 28, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/submission-email-settings-form branch August 28, 2024 10:04
@RODO94
Copy link
Contributor Author

RODO94 commented Sep 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants