refactor: Move editor console to tab #3578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
ianjon3s
force-pushed
the
ian/editor-console-tab
branch
from
41b9c6e to
9397f0d
Compare
jessicamcinchak
approved these changes
Aug 28, 2024
| )} | ||
| <StyledTab value="Console" label="Console" tabTheme="dark" /> |
DafyddLlyr
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Solid improvement!
Small nit / personal opinion would be that the black is maybe too dark. I'm not sure if a colour close to the header would work a bit better maybe?
I think there's a whole redesign we could do here anyway, and using a lib like https://react-json-view.microlink.io/ to make the whole "console" concept a whole lot more useful!
|
Thanks both, I agree the dark is somewhat overpowering, I've changed to the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🚧 Edit sidebar icon replacement pt2 🚧
Replaces console icon with a dedicated tab for the console. This is given a 'dark' theme with corresponding prop for dark tabs.
I've also moved
StyledTabto its own file, I was unsure whether this should remain in the current folder, or be moved to the wider UI components folders, as it is only used in this place. Open to suggestions on this one.Example:
https://3578.planx.pizza/lambeth/apply-for-planning-permission