tidy: release add Team Editor feature #3580
Conversation
…s/AddNewEditorModal.tsx Co-authored-by: Dafydd Llŷr Pearson <[email protected]>
|
Removed vultr server and associated DNS entries |
| setShowSuccessToast, | ||
| setShowErrorToast, |
There was a problem hiding this comment.
This is the sort of thing I hope to get rid of with a useToast hook in another PR 😁
| if (err.message === "Unable to create user") { | ||
| setShowErrorToast(true); | ||
| } |
There was a problem hiding this comment.
Not sure if we'll ever reach this due to the error handling already in src/lib/graphql.ts but hopefully a good fallback
| const handleCloseErrorToast = ( | ||
| _event?: React.SyntheticEvent | Event, | ||
| reason?: string, | ||
| ) => { | ||
| if (reason === "clickaway") { | ||
| return; | ||
| } | ||
|
|
||
| setShowErrorToast(false); |
There was a problem hiding this comment.
Leaving this as duplicated for now and will revisit with a useToast hook 🤞
There was a problem hiding this comment.
Great! All looks good, just the small issue highlighted by @jessicamcinchak on Slack but then I think that's it 🙌
| @@ -11,7 +15,7 @@ export const createAndAddUserToTeam = async ( | |||
| teamSlug: string, | |||
| ) => { | |||
| // NB: the user is hard-coded with the 'teamEditor' role for now | |||
| const response = (await client.mutate({ | |||
| const response: CreateAndAddUserResponse = await client.mutate({ | |||
There was a problem hiding this comment.
FYI: client.mutate also accepts a generic which will automatically wrap the provided type with FetchResult, e.g. client.mutate<MyType>
Ticket: https://trello.com/c/piMcGsJa/2973-add-user-in-editor
✅ Done