style: Simplify editor sidebar tabs #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Aug 29, 2024
| : theme.palette.text.primary, | ||
| fontWeight: FONT_WEIGHT_SEMI_BOLD, | ||
| color: theme.palette.text.primary, | ||
| boxShadow: `inset 0 -3px 0 ${theme.palette.warning.main}`, |
There was a problem hiding this comment.
nit: not sure I like the use of the "warning" color for the underline now that we've been incorporating it for actual warnings (eg publish validation checks) - would the original blue be better / more neutral?
There was a problem hiding this comment.
Good shout, I was going for something that satisfies the following:
- Is somewhere visually between and contrasty to both black & white, so is visible as a marker for both dark & light tabs
- Is not the primary action colour, as we use this to mark something that should be interacted with (rather than something that is "active")
The warning colour was an easy/lazy choice here (also leaning a bit too far into Github's tab styling 😀). I'll update to be the status agnostic "info" light blue colour that we use in the PlanX public interface, as this also satisfies the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplify the sidebar tabs so that they don't require a colour theme prop, and also take up less visual space.
Before:
After:
Preview:
https://3591.planx.pizza/lambeth/apply-for-planning-permission