refactor: add useToast hook for toast notifications #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamdelion
force-pushed
the
jh/use-toast-hook
branch
from
5173f4c to
cefb523
Compare
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Sep 2, 2024
| }: Readonly<{ children: ReactNode }>) => { | ||
| const [state, dispatch] = useReducer(toastReducer, initialState); | ||
| const addToast = (type: ToastType, message: string) => { | ||
| const id = Math.floor(Math.random() * 10_000_000); |
There was a problem hiding this comment.
nit: we also have the uuid package available on the frontend which would let you generate a unique uuid id like const id = uuidV4()(consistent with how we generate session ids) - happy for this to work either way though / chances of unintentionally colliding/non-unique IDs seems veryyy low here 🙂
There was a problem hiding this comment.
Nice tip thanks! I'll include that in the next PR 👍
| default: | ||
| // @ts-ignore | ||
| // Typescript complains because action is of type 'never' here | ||
| throw new Error(`Unhandled action type: ${action.type}`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Replacing everywhere we use:
With
toast.success(message)🎉Testing
An easy place to test this is in the Team Members page, when you've successfully added a new editor. You should see the usual toast message pop up on success.