feat(map-and-label): Better tab error styling #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Aug 30, 2024
Comment on lines
+79
to
+81
| borderRight: `12px solid ${theme.palette.error.main}`, | ||
| // Appear over tab indicator | ||
| zIndex: 2, |
There was a problem hiding this comment.
This is a little hacky as the tabs are buttons which are slightly hidden / obscured by the TabPanel itself (see below).
@ianjon3s Would love another pair of eyes on this if you get a chance!
jessicamcinchak
approved these changes
Aug 30, 2024
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/mal-tab-nice-styles
branch
from
d2d0548 to
70b895e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #3589 (comment) for context