fix: handle no existing team members case when adding a new editor #3608
Conversation
| {showAddMemberButton && ( | ||
| <Snackbar | ||
| open={showSuccessToast} | ||
| autoHideDuration={6000} | ||
| onClose={handleCloseSuccessToast} | ||
| > | ||
| <Alert | ||
| onClose={handleCloseSuccessToast} | ||
| severity="success" | ||
| sx={{ width: "100%" }} | ||
| > | ||
| Successfully added a user | ||
| </Alert> | ||
| </Snackbar> | ||
| )} | ||
| {showAddMemberButton && ( | ||
| <Snackbar | ||
| open={showErrorToast} | ||
| autoHideDuration={6000} | ||
| onClose={handleCloseErrorToast} | ||
| > | ||
| <Alert | ||
| onClose={handleCloseErrorToast} | ||
| severity="error" | ||
| sx={{ width: "100%" }} | ||
| > | ||
| Failed to add new user, please try again | ||
| </Alert> | ||
| </Snackbar> |
There was a problem hiding this comment.
This is unwieldy, should be removed in upcoming useToast PR
|
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
Code changes look great here - thanks for fix 👍
Looks like this pizza has an API & ShareDB issue (just flakey & unrelated to your changes I suspect!). Since this is such a straightforward & tested change, happy for this to simply merge to staging and double check there once deployed, or would suggest logging into Vultr, destroying the instance & DNS, then re-running CI from scratch and I'd guess new pizza will be better?
Thanks @jessicamcinchak - I've destroyed the instance (I assume DNS goes along with it?) but now getting an earlier fail in CI on the upsert vultr instance job. Have I missed a step? |
|
@jamdelion - when manually destroying in Vultr, the instance & DNS are annoyingly separate pages/actions - three click minimum! Just logged in & looks like your instance was properly destroyed, but DNS were still there: https://my.vultr.com/dns/edit/?domain=planx.pizza#dns-records - in future just need to also remove A & CNAME records from that page too! (I've done it here - so if you "Re-run failed job" should get further this time? 🤞)
|
Fixes case where the 'add' button wasn't visible for teams where there were no team editors already.
Trello ticket: https://trello.com/c/piMcGsJa/2973-add-user-in-editor
Fix for comment raised in Slack: https://opensystemslab.slack.com/archives/C5Q59R3HB/p1724945320946359?thread_ts=1724942587.700829&cid=C5Q59R3HB