fix(e2e): Move submissionEmail to createTeam args #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RODO94
added a commit
to theopensystemslab/planx-core
that referenced
this pull request
Sep 3, 2024
Remove `$submissionEmail` variable type from mutation to allow planx-new to add `submissionEmail` as argument passed into `createTeam()` This fix enables the planx-new e2e regression fix. theopensystemslab/planx-new#3613
RODO94
force-pushed
the
rory/fix-submission-email-revert
branch
from
8f3ed66 to
3ead0d2
Compare
|
Ended up rebasing to add in the changes we reverted before, so it threw off all the tests. Reverted changes have now been re-added. |
jessicamcinchak
approved these changes
Sep 3, 2024
editor.planx.uk/package.json
Outdated
| "@opensystemslab/map": "1.0.0-alpha.2", | ||
| "@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#d46df8d", | ||
|
|
There was a problem hiding this comment.
Can you please remove this empty line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
submissionEmailinto the args ofcreateTeam()similar to the handling ofreferenceCode.export const setup = async () => { await setUpMocks(); const teamId = await createTeam({ ++ settings: { referenceCode: "ABC", submissionEmail: TEST_EMAIL }, }); const userId = await createUser(); await setupMockBopsSubmissionUrl(teamId); const world = { teamId, userId }; return world; };This change comes in line with changes in planx-core to the createTeam mutation: theopensystemslab/planx-core#499