fix: List component input spacing #3615
Conversation
| display: "flex", | ||
| flexDirection: "column", | ||
| gap: theme.spacing(1.5), | ||
| })); |
There was a problem hiding this comment.
Can you please take a look at this PR that merged last week - #3596
Since these fields are now used in two separate places (List active cards & MapAndLabel tabs) I think we want to set this as an sx prop on List-specific instane of this component so MapAndLabel can maintain it's own unique spacing too !
There was a problem hiding this comment.
Ideally we want the spacing to be the same across the two, as we're essentially showing [small variations of] the same form inputs in different wrappers. To me it makes more sense to control this at the wrapper level rather than have to define twice.
There was a problem hiding this comment.
I personally anticipate that we're going to be getting feedback from two direction soon even though these are similar from our perspective and the flexibility is going to come in handy.
But trust your expertise on this - if you'd like to just style once here via the ListRows styled component then that's fine, but please then revert/remove sx prop recently added to generic Box otherwise MapAndLabel implementation currently confusing has "double" styles applied here and hard to unpick which overrides other?
Happy to approve after that !
There was a problem hiding this comment.
Taken on board, for simplicity I've reintroduced the sx to SchemaFields.tsx and included specific styling in the component to fix the List Component spacing. If we find the styles are replicated after feedback I'll just in and make the styles global.
|
Removed vultr server and associated DNS entries |
What does this PR do?
Adds padding to list component inputs so that labels are correctly visually associated with corresponding inputs.
Before:
After:
