style: Map + label tab style update #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
ianjon3s
force-pushed
the
ian/map-label-tab-styles
branch
from
d3d59ba to
bf0b577
Compare
jessicamcinchak
approved these changes
Sep 3, 2024
| borderRight: `12px solid ${theme.palette.error.main}`, | ||
| // Appear over tab indicator | ||
| zIndex: 2, | ||
| borderLeft: `5px solid ${theme.palette.error.main}`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a basic level of styling to the MUI tabs on Map + Label to bring them in line with PlanX components.
A notable change is moving the error indicator to the left-side of the tab, this prevents conflict with the active tab marker, is consistent with our other usage of error marking, and prevents having to extend the error border to protrude past the overhang.
On that note I spent an unreasonable amount of time trying to figure our why MUI tabs use this overhang, any attempt to rectify it, breaks the scrollbar/flex system.
Before:
After:
