Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initial works to trees feedback #3618

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix: initial works to trees feedback #3618

merged 3 commits into from
Sep 4, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Sep 3, 2024 •
edited
Loading

Working through feedback here: https://opensystemslab.slack.com/archives/C5Q59R3HB/p1725376092471139

  • List option schema should order the "map" field first, rather than last (not removing original schema yet)
  • "DateInput" field no longer throws a type error when tabbing through
  • "Cancel" button should be hidden on initial List item

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak marked this pull request as ready for review September 4, 2024 06:26
@jessicamcinchak jessicamcinchak requested a review from a team September 4, 2024 06:26
ianjon3s
ianjon3s approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixes working as expected 🙌

@jessicamcinchak
Copy link
Member Author

[EPIC] Allow applicants to 'work to trees' to see and add more information about protected trees on a map

@jessicamcinchak jessicamcinchak merged commit a7d4eaa into main Sep 4, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/mal-test-feedback-0 branch September 4, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianjon3s ianjon3s ianjon3s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamcinchak @ianjon3s