Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map-and-label): when modifying features on the map, tabs should stay ordered by label not recently changed #3626

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Sep 4, 2024

Follows on from #3612 & theopensystemslab/map#493 - we stabilised labels directly on the map features themselves, but not the tabs

Previously: add three points to the map, modify point #2, tabs 2 & 3 swap order

Now: map and tab order are stable when modifying

Copy link

github-actions bot commented Sep 4, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak requested a review from a team September 5, 2024 08:26
Copy link
Contributor

@jamdelion jamdelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix :)

@jessicamcinchak jessicamcinchak merged commit 4db9b3a into main Sep 5, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/stable-tab-order branch September 5, 2024 09:31
RODO94 pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants