Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Fieldset and legend for list/map date input #3631

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Sep 5, 2024

What does this PR do?

Addresses accessibility issue in the date input generated by schema, in that a label (Expected completion date in this case) was not correctly associated with a form field.

I've introduced the <fieldset> with child <legend> pattern to create this association.

Copy link

github-actions bot commented Sep 5, 2024

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s marked this pull request as ready for review September 5, 2024 15:16
@ianjon3s ianjon3s requested a review from a team September 5, 2024 15:16
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@ianjon3s ianjon3s merged commit 1e9757b into main Sep 6, 2024
12 checks passed
@ianjon3s ianjon3s deleted the ian/a11y-map-label-date-input branch September 6, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants