refactor: tidy up submission_email references
#3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RODO94
force-pushed
the
rory/submission-email-removals
branch
from
4261eb9 to
0510c86
Compare
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Sep 6, 2024
RODO94
added a commit
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR switches some of the references and pulls in changes made in planx-core here: theopensystemslab/planx-core#500
Took the opportunity to switch some naming away from
NotifyPersonalisationand worded it more towards where the information lives,team_settings.Ran regression testing locally and all still passing.
Once the planx-core PR is merged, I'll switch the package.json references and mark this as ready for review