style: Layout for inactive list card with map #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Sep 6, 2024
| @@ -115,39 +124,58 @@ const InactiveListCard: React.FC<{ | |||
| const { schema, formik, removeItem, editItem, isPageComponent } = | |||
| useListContext(); | |||
|
|
|||
| const mapPreview = schema.fields.find( | |||
| (field) => field.data.fn === "features", | |||
| ); | |||
There was a problem hiding this comment.
nit: we decided to make the fn user-configurable, so I think we'll want this to be based on field.type === "map" rather than relying on fn = "features"
There was a problem hiding this comment.
Thanks for spotting, have updated 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates layout of the inactive list card so that cards with maps are arranged in a horizontal layout on desktop.
Also general style improvements to the list component as a whole (button contrast, table column widths).
Preview:
