feat: Navigate to node from search results #3650
Conversation
DafyddLlyr
changed the title
DafyddLlyr
force-pushed
the
dp/search-get-url-for-node
branch
from
ee223e2 to
53441f6
Compare
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/search-get-url-for-node
branch
2 times, most recently
from
f936cc0 to
842bd00
Compare
DafyddLlyr
force-pushed
the
dp/search-get-url-for-node
branch
from
842bd00 to
d47fe2a
Compare
DafyddLlyr
changed the title
| const nodePath = | ||
| node.type === ComponentType.Answer | ||
| ? `nodes/${grandparent.id}/nodes/${parent.id}/edit` | ||
| : `nodes/${parent.id}/nodes/${node.id}/edit`; |
There was a problem hiding this comment.
I think this is the only variance that controls the path used for the modal - please let me know if there's something I've missed here!
There was a problem hiding this comment.
This seems right to me here! Only edge case I possibly considered here were "Filters" - but these links work as expected testing on pizza 🙌
Plus very cool fun bonus - Search now makes visible the (wild!) fact that Filter's have a default data field flag assigned to them via the component's handleSubmit and later relied on in upcomingCardIds():
There was a problem hiding this comment.
Ha! Good catch and a fun little easter egg... 🙃
| const nodePath = | ||
| node.type === ComponentType.Answer | ||
| ? `nodes/${grandparent.id}/nodes/${parent.id}/edit` | ||
| : `nodes/${parent.id}/nodes/${node.id}/edit`; |
There was a problem hiding this comment.
This seems right to me here! Only edge case I possibly considered here were "Filters" - but these links work as expected testing on pizza 🙌
Plus very cool fun bonus - Search now makes visible the (wild!) fact that Filter's have a default data field flag assigned to them via the component's handleSubmit and later relied on in upcomingCardIds():
| const url = getURLForNode("reservoirDogsAnswer"); | ||
| expect(url).toEqual( | ||
| "/testTeam/testFlow,tarantinoPortal,moviesPortal/nodes/tarantinoPortal/nodes/tarantinoMovieQuestion/edit", | ||
| ); |
Just a heads up that there's two minor limitations to this as it's currently written -
Both on my to do list to take a look at! |
Small bug I noticed when working on theopensystemslab/planx-new#3650
What does this PR do?
getPathForNode()to construct a PlanX relative URLTest flow on Pizza - https://3650.planx.pizza/testing/flow-navigation-search
Prior art - #3460
Screen.Recording.2024-09-11.at.16.25.57.mov
To Do (this PR)
Next step...