feat: Better handling of GovPay errors #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Sep 11, 2024
There was a problem hiding this comment.
Diffs here are quite noisy - the only change is the addition of the following line each time usePayProxy() is used -
if (statusCode >= 400) return handleGovPayErrors(govUkResponse);
jessicamcinchak
approved these changes
Sep 11, 2024
| export const handleGovPayErrors = (res: unknown) => | ||
| JSON.stringify({ | ||
| message: | ||
| "GovPay responded with an error when attempting to proxy to their API", |
There was a problem hiding this comment.
nit: can we simplify this to "GovPay API responded with an error: " please if going to bubble up to frontend error wrapper & be seen by less technical folks? Proxy is detail we/dev team know by default here?
|
Removed vultr server and associated DNS entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
Account is not fully configured. Please refer to documentation to setup your account or contact support with your error code - https://www.payments.service.gov.uk/support/What's the solution?
Also...
The pattern of proxies and nested callbacks within the Pay module is a little tricky to get around at times. I think a wider refactor here to follow a more linear middleware pattern here would make this code easier to understand and work with. It would also mean that we could ensure that logging and error handling were carried out as standard on pay endpoints. This work is outside the scope of this bug fix, but wanted to flag it!