fix: Move Flow and Feedback Lib bug fixes #3655
Conversation
|
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
Thanks for this fix, but not quite there yet!
- ✅ "Move" is working
- ✅ Send to email is working
- ❌ Feedback is NOT working - please see comment
Also please make note of "GitHub Action" warning picking up an unused import! We can ignore these for files that haven't been changed, but good to pay attention to when flagging something in your changes!
editor.planx.uk/src/lib/feedback.ts
Outdated
| @@ -25,10 +25,9 @@ export async function getInternalFeedbackMetadata(): Promise<FeedbackMetadata> { | |||
| breadcrumbs, | |||
| currentCard: node, | |||
| computePassport, | |||
| fetchCurrentTeam, | |||
| teamId, | |||
There was a problem hiding this comment.
This appears to be undefined, so I don't actually think this solution works and we need to do the fetch as before but with correct permissions/fields.
On the pizza, I determined this by:
- Noticing the Feedback Log was empty, even though the front end interaction appeared to succeed (
teamIdis required to properly filter/populate view) - Inspecting the graphql mutation
InsertFeedbackin my network tab from the/publishedlink - you'll see it's missing ateamIdvariable (graphql omits variables if undefined)- Because
team_idis a nullable field on the feedback table this doesn't throw an error (it arguably should, but that can be picked up later!)
- Because
- Double-checking
window.api.getState().teamIdin the console, which also returnedundefinedwhen on a/publishedlink- Again ultimately we probably want to fix how this is instantiated in the store so it's defined/available earlier, but if we can simply revert to the fetch here with adjusted permissions that might be quickest/most pragmatic fix right now?
There was a problem hiding this comment.
@jessicamcinchak using the updated getBySlug() with submission_email removed seems to fix this for me locally, with team_id being in the database.
Going to check it on the pizza now
There was a problem hiding this comment.
Pizza is working for me
RODO94
force-pushed
the
rory/move-flow-fix
branch
from
98b0698 to
42950cb
Compare
Cleaner branch to see all of the fixes for the
moveFlowAPI call and the Feedback library fetch.Used the
$clientinstead of$publicfor the moveFlowgetBySlug()query.Removed the fetch for
teamIdin the lib/feedback.ts and replaced it with a store value